Log in Register FAQ Memberlist Search Welcome to RCF Forum Index
alt : test.swf
Welcome to RCF
4fx3.gif 
Contact the Webmasters of RCFContact   Invite a friend to Join usRecommend   Chat in IRCChat   EZ Template Change OptionEZStyle   Listen to Internet Radio while you browse...iRadio   See your private message.Login for PMs   Important LinksLinks
Member Website LinksWeb Links   Play/View our GamesGames   Register.Register
calendar_open_closeCalendar 
A mod request for NightRider (if possible)
Post new topic   Reply to topic View previous topic :: View next topic
Goto page: Previous  1, 2
Welcome to RCF Forum Index -> Area 51 - phpBB & Easymod Tech Support Add To Bookmarks
Re: A mod request for NightRider (if possible)
PostPosted: 01/08/2010 1:16 PM Reply with quote
Sparrow
cavallino
Sparrow
Posts 21
Word Cnt. 2,213
BDay N/A
Sign N/A
Joined: Dec 11, 2005
Local time: 2:56 PM
blank.gif
Hi again NightRider,
I have already a little problem... following this phpbb update.
When I open a topic, a white page comes up with the following message:

Code:
Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /home/public_html/board/viewtopic.php on line 1282


At line 1282 of viewtopic.php I have this (its one of the lines we have modified in the previous post):

Code:
   $topic_mod .= "<a onclick=\"return AJAXTopicDelete($topic_id, '". $lang['Confirm_delete_topic'] ."');\" href="' . append_sid("modcp.$phpEx?" . POST_TOPIC_URL . "=$topic_id&mode=delete&p_sid=" . $userdata['priv_session_id']) . '"><img src="' . $images['topic_mod_delete'] . '" alt="' . $lang['Delete_topic'] . '" title="' . $lang['Delete_topic'] . '" border="0" /></a>&nbsp;';


Do you have an idea on where is the syntax error? Can you help?  Rolling Eyes Thanks
Back to Top
View user's profile Find all posts by cavallino Send private message  
Re: A mod request for NightRider (if possible)
PostPosted: 01/08/2010 2:40 PM Reply with quote
Site Admin
Nightrider
Site Admin
Posts 30756
Word Cnt. 2,628,677
BDay Jul 28
Sign Leo
Sex Sex:Male
Joined: Sep 25, 2004
Local time: 3:56 PM
Location: St Pete, FL
peace.gif
Did you install this with EM?  If so, do you know how to Restore your EM Backups?  The problem is that the single and double quotes are all messed up.  I imagine the same problem will be on all the other lines that were modified.  In fact, it appears that the original code improperly mixed single and double quotes for this code.  The syntax was generally correct, but it is bad coding practice to mix single and double quotes to designate text strings in the same line of code.  It appears that these lines were modified by different coders with different styles, some using single quotes to designate strings and others using double quotes.  The mixture of the two makes the code very confusing to follow...

Can you provide a text link to your viewtopic.php file?  I should be able to clean this up for you.  But while you're waiting, you should restore your backups...

munky2
Back to Top
View all pictures posted by this userView user's profile Find all posts by Nightrider Send private message   AIM Address Yahoo Messenger Phoogle Map ICQ Number
Re: A mod request for NightRider (if possible)
PostPosted: 01/08/2010 5:33 PM Reply with quote
Sparrow
cavallino
Sparrow
Posts 21
Word Cnt. 2,213
BDay N/A
Sign N/A
Joined: Dec 11, 2005
Local time: 2:56 PM
blank.gif
Yes NightRider, I have already put the backup online.

I attach you here the affected viewtopic.php file, hoping that you can try to clean it up.
Change the extension of the file from AI to PHP, I renamed this file in viewtopic.ai just to allow the attachment here.
Back to Top
View user's profile Find all posts by cavallino Send private message  
Re: A mod request for NightRider (if possible)
PostPosted: 01/10/2010 4:12 PM Reply with quote
Site Admin
Nightrider
Site Admin
Posts 30756
Word Cnt. 2,628,677
BDay Jul 28
Sign Leo
Sex Sex:Male
Joined: Sep 25, 2004
Local time: 3:56 PM
Location: St Pete, FL
peace.gif
Ok, try this.  It is impossible for me to completely test this since it includes functionality not installed in any of my forums...

viewtopic.txt

You will need to replace the txt extension with php before uploading this to your server...

Or you can download this archived copy, extract it, then upload the viewtopic.php file to your server:

viewtopic.zip

munky2
Back to Top
View all pictures posted by this userView user's profile Find all posts by Nightrider Send private message   AIM Address Yahoo Messenger Phoogle Map ICQ Number
Re: A mod request for NightRider (if possible)
PostPosted: 01/11/2010 3:48 AM Reply with quote
Sparrow
cavallino
Sparrow
Posts 21
Word Cnt. 2,213
BDay N/A
Sign N/A
Joined: Dec 11, 2005
Local time: 2:56 PM
blank.gif
NightRider!
Infinate thanks to you.

I have re-uploaded all backed up files for 2.0.24 modification along with your modded viewtopic.php and I have no more the syntax error!
I have tested forum a little bit and everything seems to be running fine!
Back to Top
View user's profile Find all posts by cavallino Send private message  
Re: A mod request for NightRider (if possible)
PostPosted: 01/11/2010 4:00 AM Reply with quote
Site Admin
Nightrider
Site Admin
Posts 30756
Word Cnt. 2,628,677
BDay Jul 28
Sign Leo
Sex Sex:Male
Joined: Sep 25, 2004
Local time: 3:56 PM
Location: St Pete, FL
peace.gif
Good deal.  That is very complicated code, so I was hoping that I didn't miss anything.  I really don't like it when I don't have the ability to test it in advance.  I didn't bother rewriting everything to clean up the mixture of single and double quotes since you may want to install other MODs that could add code to this section...

Let me know if you uncover any problems...

headbang
Back to Top
View all pictures posted by this userView user's profile Find all posts by Nightrider Send private message   AIM Address Yahoo Messenger Phoogle Map ICQ Number
Re: A mod request for NightRider (if possible)
PostPosted: 01/12/2010 5:28 AM Reply with quote
Sparrow
cavallino
Sparrow
Posts 21
Word Cnt. 2,213
BDay N/A
Sign N/A
Joined: Dec 11, 2005
Local time: 2:56 PM
blank.gif
Yeah, I can understand you NightRider. I think that no one, except you, would ever dare to put a hand inside that heavily modded viewtopic and other files related to that board Smile
At this time I have heavily tested many functions related to topics and messages involving viewtopic and there are absolutely no problems. Since the update the board seems also running a bit faster than usual...
Back to Top
View user's profile Find all posts by cavallino Send private message  
Re: A mod request for NightRider (if possible)
PostPosted: 01/12/2010 9:34 PM Reply with quote
Site Admin
Nightrider
Site Admin
Posts 30756
Word Cnt. 2,628,677
BDay Jul 28
Sign Leo
Sex Sex:Male
Joined: Sep 25, 2004
Local time: 3:56 PM
Location: St Pete, FL
peace.gif
cavallino wrote:
At this time I have heavily tested many functions related to topics and messages involving viewtopic and there are absolutely no problems. Since the update the board seems also running a bit faster than usual...

That's great news.  I would like to believe that something in this update helped to improve the performance of your community, but I doubt that it would be true.  If your forum is performing better, it is probably due to an improvement with your host's servers or a speed increase with your ISP...

munky2
Back to Top
View all pictures posted by this userView user's profile Find all posts by Nightrider Send private message   AIM Address Yahoo Messenger Phoogle Map ICQ Number
 Post new topic  Reply to topic
Information
Welcome to RCF Forum Index -> Area 51 - phpBB & Easymod Tech Support

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
You cannot attach files in this forum
You cannot download files in this forum
All times are GMT - 5 Hours
Goto page: Previous  1, 2
Page 2 of 2


Add To Bookmarks

 
  
  

Get IX Get IX
  Prices Based on 24 Month Billing Cycle  

  Google

Powered by phpBB © 2001, 2005 phpBB Group
  ImageShack  
  Putfile  
  TinyURL  
  CommonDreams  
  Log in  

Page generation time: 0.815s (PHP: 29% - SQL: 71%) - SQL queries: 57 - GZIP enabled - Debug on