| Re: A mod request for NightRider (if possible) | |
Posted: 01/08/2010 1:16 PM |
|
|
|
|
Sparrow |
Posts |
21 |
Word Cnt. |
2,213 |
BDay |
N/A |
Sign |
N/A |
|
|
|
|
|
Joined: Dec 11, 2005
Local time: 6:47 PM
|
|
|
|
|
|
Hi again NightRider,
I have already a little problem... following this phpbb update.
When I open a topic, a white page comes up with the following message:
Code:
|
Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /home/public_html/board/viewtopic.php on line 1282
|
At line 1282 of viewtopic.php I have this (its one of the lines we have modified in the previous post):
Code:
|
$topic_mod .= "<a onclick=\"return AJAXTopicDelete($topic_id, '". $lang['Confirm_delete_topic'] ."');\" href="' . append_sid("modcp.$phpEx?" . POST_TOPIC_URL . "=$topic_id&mode=delete&p_sid=" . $userdata['priv_session_id']) . '"><img src="' . $images['topic_mod_delete'] . '" alt="' . $lang['Delete_topic'] . '" title="' . $lang['Delete_topic'] . '" border="0" /></a> ';
|
Do you have an idea on where is the syntax error? Can you help? Thanks |
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/08/2010 2:40 PM |
|
|
|
|
Site Admin |
Posts |
30756 |
Word Cnt. |
2,628,678 |
BDay |
Jul 28 |
Sign |
Leo |
Sex |
|
|
|
|
Joined: Sep 25, 2004
Local time: 7:47 PM
Location: St Pete, FL
|
|
|
|
|
|
Did you install this with EM? If so, do you know how to Restore your EM Backups? The problem is that the single and double quotes are all messed up. I imagine the same problem will be on all the other lines that were modified. In fact, it appears that the original code improperly mixed single and double quotes for this code. The syntax was generally correct, but it is bad coding practice to mix single and double quotes to designate text strings in the same line of code. It appears that these lines were modified by different coders with different styles, some using single quotes to designate strings and others using double quotes. The mixture of the two makes the code very confusing to follow...
Can you provide a text link to your viewtopic.php file? I should be able to clean this up for you. But while you're waiting, you should restore your backups...
|
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/08/2010 5:33 PM |
|
|
|
|
Sparrow |
Posts |
21 |
Word Cnt. |
2,213 |
BDay |
N/A |
Sign |
N/A |
|
|
|
|
|
Joined: Dec 11, 2005
Local time: 6:47 PM
|
|
|
|
|
|
Yes NightRider, I have already put the backup online.
I attach you here the affected viewtopic.php file, hoping that you can try to clean it up.
Change the extension of the file from AI to PHP, I renamed this file in viewtopic.ai just to allow the attachment here. |
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/10/2010 4:12 PM |
|
|
|
|
Site Admin |
Posts |
30756 |
Word Cnt. |
2,628,678 |
BDay |
Jul 28 |
Sign |
Leo |
Sex |
|
|
|
|
Joined: Sep 25, 2004
Local time: 7:47 PM
Location: St Pete, FL
|
|
|
|
|
|
Ok, try this. It is impossible for me to completely test this since it includes functionality not installed in any of my forums...
viewtopic.txt
You will need to replace the txt extension with php before uploading this to your server...
Or you can download this archived copy, extract it, then upload the viewtopic.php file to your server:
viewtopic.zip
|
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/11/2010 3:48 AM |
|
|
|
|
Sparrow |
Posts |
21 |
Word Cnt. |
2,213 |
BDay |
N/A |
Sign |
N/A |
|
|
|
|
|
Joined: Dec 11, 2005
Local time: 6:47 PM
|
|
|
|
|
|
NightRider!
Infinate thanks to you.
I have re-uploaded all backed up files for 2.0.24 modification along with your modded viewtopic.php and I have no more the syntax error!
I have tested forum a little bit and everything seems to be running fine! |
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/11/2010 4:00 AM |
|
|
|
|
Site Admin |
Posts |
30756 |
Word Cnt. |
2,628,678 |
BDay |
Jul 28 |
Sign |
Leo |
Sex |
|
|
|
|
Joined: Sep 25, 2004
Local time: 7:47 PM
Location: St Pete, FL
|
|
|
|
|
|
Good deal. That is very complicated code, so I was hoping that I didn't miss anything. I really don't like it when I don't have the ability to test it in advance. I didn't bother rewriting everything to clean up the mixture of single and double quotes since you may want to install other MODs that could add code to this section...
Let me know if you uncover any problems...
|
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/12/2010 5:28 AM |
|
|
|
|
Sparrow |
Posts |
21 |
Word Cnt. |
2,213 |
BDay |
N/A |
Sign |
N/A |
|
|
|
|
|
Joined: Dec 11, 2005
Local time: 6:47 PM
|
|
|
|
|
|
Yeah, I can understand you NightRider. I think that no one, except you, would ever dare to put a hand inside that heavily modded viewtopic and other files related to that board
At this time I have heavily tested many functions related to topics and messages involving viewtopic and there are absolutely no problems. Since the update the board seems also running a bit faster than usual... |
|
|
|
|
Back to Top |
|
|
| Re: A mod request for NightRider (if possible) | |
Posted: 01/12/2010 9:34 PM |
|
|
|
|
Site Admin |
Posts |
30756 |
Word Cnt. |
2,628,678 |
BDay |
Jul 28 |
Sign |
Leo |
Sex |
|
|
|
|
Joined: Sep 25, 2004
Local time: 7:47 PM
Location: St Pete, FL
|
|
|
|
|
|
cavallino wrote:
|
At this time I have heavily tested many functions related to topics and messages involving viewtopic and there are absolutely no problems. Since the update the board seems also running a bit faster than usual...
|
That's great news. I would like to believe that something in this update helped to improve the performance of your community, but I doubt that it would be true. If your forum is performing better, it is probably due to an improvement with your host's servers or a speed increase with your ISP...
|
|
|
|
|
Back to Top |
|
|
| Information | |
|